deployment: add native config layers for the testing overlays#14645
Draft
nimrod-starkware wants to merge 1 commit into
Draft
Conversation
This was referenced Jun 28, 2026
|
This change is |
This was referenced Jun 28, 2026
Contributor
Author
This was referenced Jun 28, 2026
Draft
nimrod-starkware
force-pushed
the
nimrod/jsonnet/testing-overlays-native-layers
branch
from
39a3bb3 to
e704bbc
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/testing-overlays-native-layers
branch
from
e704bbc to
b9c5305
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/dummy-for-testing-native-layer
branch
from
082340c to
8852b34
Compare
Under the native config path an overlay's config comes from sequencer_config.jsonnet layers (YAML sequencerConfig is ignored). The testing/node-0 and testing/all-constructs overlays (synthed by the cdk8s-test and hybrid-system-test CI jobs) had no native layer, so native synth aborted on unconditionally-read overrides.* keys (validator_id, the outer committer cache_size, ...). - testing/node-0: full value-parity native layer (the folded translation of its combined YAML sequencerConfig). It is deployed live by hybrid_system_test, so values are load-bearing; guarded by a strict mirror test (test_node0_layer_jsonnet_mirrors_combined_yaml). - testing/all-constructs: a structure-validation stub supplying exactly the unconditional overrides.* reads the base layer does not provide, with clearly-dummy immaterial values (its synth is only kubectl-validated for manifest structure); guarded by a synth-success test (test_all_constructs_native_config_synthesizes). This lets every CI-synthed overlay build under native, before the default flip. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
nimrod-starkware
force-pushed
the
nimrod/jsonnet/testing-overlays-native-layers
branch
from
b9c5305 to
66a55ac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Under the native config path an overlay's config comes from sequencer_config.jsonnet
layers (YAML sequencerConfig is ignored). The testing/node-0 and testing/all-constructs
overlays (synthed by the cdk8s-test and hybrid-system-test CI jobs) had no native layer,
so native synth aborted on unconditionally-read overrides.* keys (validator_id, the outer
committer cache_size, ...).
YAML sequencerConfig). It is deployed live by hybrid_system_test, so values are
load-bearing; guarded by a strict mirror test (test_node0_layer_jsonnet_mirrors_combined_yaml).
overrides.* reads the base layer does not provide, with clearly-dummy immaterial values
(its synth is only kubectl-validated for manifest structure); guarded by a synth-success
test (test_all_constructs_native_config_synthesizes).
This lets every CI-synthed overlay build under native, before the default flip.
Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com